jdaugherty commented on PR #14922: URL: https://github.com/apache/grails-core/pull/14922#issuecomment-3090123545
@matrei We do not need the visitor, only the factory. In the event we need to customize it, we can simply fork it again. One of the reasons Spring rewrote it was because of performance. The other major concern is the old implementation had several known issues - from bugs to not supporting graalvm. @jamesfredley the more I think about this, I think its more important to be correct. If it does introduce a performance regression we can fork the Spring version and apply a similar approach that Graeme did. However, if it was significantly slower we would have seen it between builds. I suspect it will only affect larger apps, like mine. In which case we will just have to do further work at that time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@grails.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
