matrei commented on PR #14903: URL: https://github.com/apache/grails-core/pull/14903#issuecomment-3092320859
> do either of you have time to suggest changes to the checkstyle config and reformat incrementally? I was hoping this could be a joint effort =) As I understand it, this PR is a mix of formatting changes from different tools and settings and also perhaps manual changes in the same commit. I think it would be easier to do a joint effort if we did step-wise changes, with explanations for each change and only doing the changes that are suggested by the tools. As it is now I have trouble understanding why certain style changes where made, sometimes in one place, but not in another. There are also changes made to Groovy files and test files, even though Checkstyle supposedly only works with Java files and test files are exempted. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@grails.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
