jdaugherty commented on code in PR #14929:
URL: https://github.com/apache/grails-core/pull/14929#discussion_r2226894924
##########
grails-gradle/docs-core/src/main/groovy/grails/doc/dropdown/CreateReleaseDropDownTask.groovy:
##########
@@ -80,6 +87,9 @@ abstract class CreateReleaseDropDownTask extends DefaultTask {
modifiedPagesDirectory =
objects.directoryProperty().convention(project.layout.buildDirectory.dir("modified-pages"))
gitTags =
objects.fileProperty().convention(project.layout.buildDirectory.file('git-tags.txt'))
minimumVersion = objects.property(SoftwareVersion).convention(new
SoftwareVersion(major: 5))
+ docBaseUrl =
objects.property(String).convention("https://docs.grails.org";)
+ versionHtml =
objects.property(String).convention("<p><strong>Version:</strong> " +
projectVersion.get() + "</p>")
Review Comment:
The convention for this needs to be a provider so this can be evaluated only
if the task executes. Like this:
.convention(project.provider{ "<p><strong>Version:</strong> " +
projectVersion.get() + "</p>" })
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@grails.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
