jdaugherty commented on code in PR #14988: URL: https://github.com/apache/grails-core/pull/14988#discussion_r2283577811
########## LICENSE: ########## @@ -236,7 +236,7 @@ See licenses/LICENSE-CDDL.txt for the full license terms. -------------------------------------------------------------------------- -This product includes software developed by the OpenSymphony Group (http://www.opensymphony.com/). It uses Sitemesh2, +This product includes software developed by the OpenSymphony Group (https://github.com/sitemesh). It uses Sitemesh2, Review Comment: This has to remain this way, the license requires this text ########## LICENSE: ########## @@ -1,7 +1,7 @@ Apache License Version 2.0, January 2004 - http://www.apache.org/licenses/ + https://www.apache.org/licenses/ Review Comment: I tried to make this change previously and received push back because its text does not match the link text. ########## grails-doc/src/en/guide/async/rxjava/asyncRxGorm.adoc: ########## @@ -17,7 +17,7 @@ specific language governing permissions and limitations under the License. //// -https://gorm.grails.org/{projectVersion}/rx/manual/[RxGORM] is new implementation of GORM that has the following goals: +https://gorm.grails.org/latest/rx/manual/[RxGORM] is new implementation of GORM that has the following goals: Review Comment: We need to extract this into a variable. If we ever start publishing those docs again, this will be wrong. ########## gradle.properties: ########## @@ -5,7 +5,7 @@ # (the "License"); you may not use this file except in compliance with # the License. You may obtain a copy of the License at # -# http://www.apache.org/licenses/LICENSE-2.0 +# https://www.apache.org/licenses/LICENSE-2.0 Review Comment: This needs to match the official license text so it must remain ########## NOTICE: ########## @@ -21,5 +21,5 @@ The original XML Schemas for Java EE Deployment Descriptors: may be obtained from: http://www.oracle.com/webfolder/technetwork/jsc/xml/ns/javaee/index.html -This product includes software developed by the OpenSymphony Group (http://www.opensymphony.com/). It uses Sitemesh2, +This product includes software developed by the OpenSymphony Group (https://github.com/sitemesh). It uses Sitemesh2, Review Comment: This has to remain this way because the license requires this text ########## grails-doc/src/en/guide/async/events/asyncGormEvents.adoc: ########## @@ -17,7 +17,7 @@ specific language governing permissions and limitations under the License. //// -GORM defines a link:{gormApiDocs}/org/grails/datastore/mapping/engine/event/package-summary.html[number of useful events] that you can listen for. Review Comment: So we still publish both a gorm specific api and then all of the grails api. Shouldn't we refer to the specific one? If not can we stop publishing it since its a duplicate? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@grails.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
