jdaugherty commented on code in PR #14994:
URL: https://github.com/apache/grails-core/pull/14994#discussion_r2288698448
##########
grails-forge/grails-forge-core/src/main/java/org/grails/forge/feature/database/H2.java:
##########
@@ -20,12 +20,18 @@
import io.micronaut.context.annotation.Primary;
import jakarta.inject.Singleton;
+import org.grails.forge.application.ApplicationType;
import org.grails.forge.application.generator.GeneratorContext;
import org.grails.forge.build.dependencies.Dependency;
+import org.grails.forge.feature.DefaultFeature;
+import org.grails.forge.feature.Feature;
+import org.grails.forge.options.Options;
+
+import java.util.Set;
@Singleton
@Primary
-public class H2 extends DatabaseDriverFeature {
+public class H2 extends DatabaseDriverFeature implements DefaultFeature {
Review Comment:
H2 isn't required unless GORM is being used. What's the thinking on adding
this as a default feature?
##########
grails-forge/grails-forge-core/src/main/java/org/grails/forge/feature/database/MongoGorm.java:
##########
@@ -52,7 +52,7 @@ public String getTitle() {
@Override
public String getDescription() {
- return "Configures GORM for MongoDB for Groovy applications";
+ return "Configure GORM for using MongoDB.";
Review Comment:
What are your thoughts about changing GORM -> Grails Data since we've
renamed the packages?
##########
grails-forge/grails-forge-core/src/main/java/org/grails/forge/feature/grails/GrailsConsole.java:
##########
@@ -41,9 +41,14 @@ public String getName() {
return "grails-console";
}
+ @Override
+ public String getTitle() {
+ return "Console";
+ }
+
@Override
public String getDescription() {
- return "Starts the Grails console, which is an extended version of the
regular Groovy console.";
+ return "A Groovy console for interactive runtime application
management and debugging.";
Review Comment:
I don't think this is correct. It's a grails console and it doesn't launch
the interactive window.
##########
grails-forge/grails-forge-core/src/main/java/org/grails/forge/feature/view/Scaffolding.java:
##########
@@ -51,12 +51,14 @@ public String getName() {
@Override
public String getTitle() {
- return "Grails Scaffolding Plugin";
+ return "Scaffolding";
Review Comment:
We distinguish between libraries for logback, but not for plugins.
Shouldn't we be consistent?
##########
grails-forge/grails-forge-core/src/main/java/org/grails/forge/feature/database/Neo4jGorm.java:
##########
@@ -44,7 +44,7 @@ public String getTitle() {
@Override
public String getDescription() {
- return "Configures GORM for Neo4j for Groovy applications";
+ return "Configure GORM for using Neo4j";
Review Comment:
Should we set a max supported version or something? If they select Neo4j
for Grails 7, it will fail ... seems like we should tell the user this isn't
supported yet.
##########
grails-forge/grails-forge-core/src/main/java/org/grails/forge/feature/database/TestContainers.java:
##########
@@ -138,6 +138,6 @@ public String getCategory() {
@Nullable
@Override
public String getThirdPartyDocumentation() {
- return "https://www.testcontainers.org/";;
+ return "https://www.testcontainers.org";;
Review Comment:
@jamesfredley changed the url to java.testcontainers.org instead of
www.testcontainers.org in the docs, so should we change that here too?
##########
grails-forge/grails-forge-core/src/main/java/org/grails/forge/feature/grailsWrapper/GrailsWrapper.java:
##########
@@ -45,12 +45,12 @@ public String getName() {
@Override
public String getTitle() {
- return "Grails Wrapper for Grails";
+ return "Grails Wrapper";
}
@Override
public String getDescription() {
- return "Gives you the ability to run grails shell from terminal.";
+ return "Enables running the Grails CLI directly without requiring a
local Grails distribution installed.";
Review Comment:
The wrapper is really a light weight installer for the delegating CLI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@grails.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
