jamesfredley commented on code in PR #14999:
URL: https://github.com/apache/grails-core/pull/14999#discussion_r2288756291
##########
dependencies.gradle:
##########
@@ -22,25 +22,25 @@
// These files are split to facilitate separation of build vs application
dependencies. These are the application dependencies.
ext {
gradleBomDependencyVersions = [
- 'ant.version' : '1.10.15',
- 'asciidoctor-gradle-jvm.version' : '4.0.4',
- 'asciidoctorj.version' : '3.0.0',
- 'asset-pipeline-gradle.version' : '5.0.14',
- 'byte-buddy.version' : '1.17.6',
- 'commons-text.version' : '1.13.1',
- 'directory-watcher.version' : '0.19.1',
- 'gradle-spock.version' : '2.3-groovy-3.0',
- 'grails-publish-plugin.version' : '7.0.0-SNAPSHOT',
- 'grails-gdoc-engine.version' : '1.0.1',
- 'jansi.version' : '1.18',
- 'javaparser-core.version' : '3.27.0',
- 'jline.version' : '2.14.6',
- 'jna.version' : '5.17.0',
- 'jquery.version' : '3.7.1',
- 'objenesis.version' : '3.4',
- 'gradle-spock.version' : '2.3-groovy-3.0',
- 'spring-boot.version' : '3.5.4',
- 'springloaded.version' : '1.2.8.RELEASE',
+ 'ant.version' : '1.10.15',
+ 'asciidoctor-gradle-jvm.version': '4.0.4',
+ 'asciidoctorj.version' : '3.0.0',
+ 'asset-pipeline-gradle.version' : '5.0.15',
Review Comment:
Given that
https://repo1.maven.org/maven2/cloud/wondrify/asset-pipeline-bom/5.0.15/asset-pipeline-bom-5.0.15.module
includes `asset-pipeline-gradle`, I think we should put
asset-pipeline-bom.version in gradleBomDependencyVersions, move
`'asset-pipeline-bom':
"cloud.wondrify:asset-pipeline-bom:${bomDependencyVersions['asset-pipeline-bom.version']}",`
up to gradleBomPlatformDependencies and then add it to `combinedPlatforms =
['spring-boot-bom': gradleBomPlatformDependencies['spring-boot-bom']] +
bomPlatformDependencies` so asset-pipeline-bom in both boms.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@grails.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
