jdaugherty commented on code in PR #15002:
URL: https://github.com/apache/grails-core/pull/15002#discussion_r2293943614
##########
grails-testing-support-core/src/main/groovy/org/grails/testing/context/junit4/GrailsTestConfiguration.java:
##########
@@ -29,7 +29,7 @@
* @author Graeme Rocher
* @since 3.0
*/
-@ContextConfiguration(loader = GrailsApplicationContextLoader.class)
+@ContextConfiguration(loader = SpringBootContextLoader.class)
Review Comment:
Why aren't we using the Grails Context?
##########
grails-testing-support-core/build.gradle:
##########
@@ -48,6 +48,7 @@ dependencies {
api project(':grails-databinding')
api project(':grails-datamapping-core')
api project(':grails-test-core')
+ api('org.spockframework:spock-core') { transitive = false }
Review Comment:
this is incudes by test-core so it should be unnecessary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@grails.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
