jdaugherty commented on code in PR #14994:
URL: https://github.com/apache/grails-core/pull/14994#discussion_r2294195311


##########
grails-forge/grails-forge-core/src/main/java/org/grails/forge/feature/cache/GrailsCache.java:
##########
@@ -69,7 +70,7 @@ public String getCategory() {
 
     @Override
     public String getDocumentation() {
-        return "https://docs.grails.org/";;
+        return "https://docs.grails.org/"; + VersionInfo.getGrailsVersion() + 
"/guide/cache.html";

Review Comment:
   This could cause confusion when there are multiple major versions though.  I 
assume the documentation is shown on the CLI somehow?  If so, I'd argue we need 
the version in all of these.  
   
   We could easily publish the snapshot version in the docs too, that would fix 
the snapshot problem.  It might also makes it better since right now after 
publishing a 6.x snapshot, we would technically have to republish a 7.x.  I 
could build the same "latest" detection logic into the snapshot publishing 
that's there for release in the github action.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@grails.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to