jdaugherty commented on PR #14925: URL: https://github.com/apache/grails-core/pull/14925#issuecomment-3220222991
> > This allows someone to fix the formatting issues after finding a solution to aprobelm / the tests. > > But shouldn't one preferably run the build locally to test changes before pushing? > > > We also need to upload the errors somewhere - they currently reference an html file that can't be viewed if it's from an action. > > Yes, any code style error reports should be uploaded to the summary page. Yes, but third party contributors may not always do that. Having a separate run makes it clear why it's failing and if it's a functionality problem or a best practice/ style issue. I also wish to use that same functionality locally at times - there have been many times where I'm debugging an issue and don't want to worry about code style locally until a solution has been found. I 100% agree we should eventually be compliant with the code style, but I want a way to opt out locally when testing or making large changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@grails.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
