matrei commented on code in PR #15099:
URL: https://github.com/apache/grails-core/pull/15099#discussion_r2390117714
##########
gradle/sbom-config.gradle:
##########
@@ -33,83 +33,91 @@ import java.time.temporal.ChronoUnit
apply plugin: 'org.cyclonedx.bom'
-project.ext.setProperty('sbomOutputLocation',
project.layout.buildDirectory.file("${findProperty('pomArtifactId') ?:
project.name}-${projectVersion}-sbom.json"))
+ext {
+ sbomOutputLocation = layout.buildDirectory.file(
+ "${findProperty('pomArtifactId') ?:
name}-$projectVersion-sbom.json"
+ )
+}
-def sbomTask = tasks.named('cyclonedxBom', CycloneDxTask)
-sbomTask.configure { CycloneDxTask it ->
+tasks.withType(CycloneDxTask).configureEach {
Review Comment:
According to the upgrade guide at:
https://github.com/CycloneDX/cyclonedx-gradle-plugin/releases/tag/cyclonedx-gradle-plugin-3.0.0-alpha-0
> New System Requirements in 3.0.0
>
> Java 17 or newer (previously supported older versions)
> Gradle 9.0 or newer (previously supported Gradle 8.0+)
>
> The plugin might be still compatible with older versions, but it's not
tested.
>
> ⚠️ Important: If you cannot upgrade to these requirements, continue using
version 2.x.x.
##########
gradle.properties:
##########
@@ -47,8 +47,8 @@ yakworksHibernateGroovyProxyVersion=1.1
# Build dependency versions not managed by BOMs
apacheRatVersion=0.8.1
gradleChecksumPluginVersion=1.4.0
-# note: the cyclonedx 3.0.0-alpha-1 still does not set the project correctly,
so we must use the older version
-gradleCycloneDxPluginVersion=2.4.0
+# note: the cyclonedx 3 requires Gradle 9
Review Comment:
According to the upgrade guide at:
https://github.com/CycloneDX/cyclonedx-gradle-plugin/releases/tag/cyclonedx-gradle-plugin-3.0.0-alpha-0
> New System Requirements in 3.0.0
>
> Java 17 or newer (previously supported older versions)
> Gradle 9.0 or newer (previously supported Gradle 8.0+)
>
> The plugin might be still compatible with older versions, but it's not
tested.
>
> ⚠️ Important: If you cannot upgrade to these requirements, continue using
version 2.x.x.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
