JonasPammer commented on code in PR #15067:
URL: https://github.com/apache/grails-core/pull/15067#discussion_r2368663669
##########
grails-geb/src/testFixtures/groovy/grails/plugin/geb/GrailsGebSettings.groovy:
##########
@@ -66,15 +68,21 @@ class GrailsGebSettings {
recordingFormat = VncRecordingFormat.valueOf(
System.getProperty('grails.geb.recording.format',
DEFAULT_RECORDING_FORMAT.name())
)
- restartRecordingContainerPerTest = Boolean.parseBoolean(
-
System.getProperty('grails.geb.recording.restartRecordingContainerPerTest',
'true')
+ restartRecordingContainerPerTest = getBooleanProperty(
+ 'grails.geb.recording.restartRecordingContainerPerTest',
+ true
)
implicitlyWait = getIntProperty('grails.geb.timeouts.implicitlyWait',
DEFAULT_TIMEOUT_IMPLICITLY_WAIT)
pageLoadTimeout = getIntProperty('grails.geb.timeouts.pageLoad',
DEFAULT_TIMEOUT_PAGE_LOAD)
scriptTimeout = getIntProperty('grails.geb.timeouts.script',
DEFAULT_TIMEOUT_SCRIPT)
+ atCheckWaiting = getBooleanProperty('grails.geb.atCheckWaiting',
DEFAULT_AT_CHECK_WAITING)
Review Comment:
ah ok yes i thought it would just pick the right one with trial and error.
yes your implementation is best as we set the default timeouts with environment
too! :+1:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
