codeconsole commented on PR #15179:
URL: https://github.com/apache/grails-core/pull/15179#issuecomment-3457655464

   > Why is `grails.` stripped in the first place in `configureForSettings`?
   > 
   > The message of the commit that added that code in 2015 is: `Infrastructure 
support to allow changing server port and enable HTTPS from command line`
   > 
   > That implies to me that this is done to convert `grails.server.port` -> 
`server.port` and `grails.server.port.https` -> `server.port.https` and 
possibly some other properties.
   > 
   > Would it not be more transparent to explicitly convert the Spring Boot 
properties that we care about in `configureForkSettings` instead of bulk 
converting every system property that starts with `grails.`?
   
   @matrei this PR isn't stripping anything.  All this PR does is reference the 
historically correct `target.dir`.  The plugin has always stripped them. I 
started down the path of not stripping them, but since it has always been like 
that, it might be beyond the scope for 7.x


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to