matrei commented on PR #15202:
URL: https://github.com/apache/grails-core/pull/15202#issuecomment-3482340055

   > I'm registering it in unit tests, and it's no longer exposed on the 
classpath like it was previously and like the other gsp tag libs are.
   
   Then, in my view, you are explicitly using it in your test implementation 
and should declare it in the `testImplementation` configuration.
   
   `@Taglib` is a runtime retention annotation and annotated classes are not 
needed on the application compile classpath. The other taglibs are available 
only because they are in `grails-gsp` and `grails-gsp` must be on the compile 
classpath as it has the `ControllerTagLibraryTraitInjector` transformation.
   
   I'm not going to stop this from being merged, but I think we should be 
restricting our dependency graphs instead of opening them up, to be able to 
reduce coupling going forward.
   
   One solution would be to add `grails-web-gsp-taglib` as an API dependency in 
`grails-testing-support-web` (with an explaining comment).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to