codeconsole commented on code in PR #15259:
URL: https://github.com/apache/grails-core/pull/15259#discussion_r2562128019
##########
build-logic/docs-core/src/main/groovy/org/apache/grails/gradle/tasks/bom/PropertyNameCalculator.groovy:
##########
@@ -28,6 +28,8 @@ import org.gradle.api.plugins.JavaPlatformPlugin
*/
class PropertyNameCalculator {
+ static final String GRAILS_VERSION_PROPERTY = 'grails.version'
Review Comment:
@jdaugherty didn't you change the bom to allow setting 131 different grails
subproject versions? I am saying overriding is better than using a grails
property for everyone because if you did that you would get version conflicts
from transitive dependencies.
I am recommending
```xml
<grails.version>7.1.0-SNAPSHOT</grails.version>
```
instead of
``` <dependency>
<groupId>org.apache.grails</groupId>
<artifactId>grails-async</artifactId>
<version>${grails.version}</version>
</dependency>
<dependency>
<groupId>org.apache.grails.async</groupId>
<artifactId>grails-async-core</artifactId>
<version>${grails.version}</version>
</dependency>
<dependency>
<groupId>org.apache.grails.async</groupId>
<artifactId>grails-async-gpars</artifactId>
<version>${grails.version}</version>
</dependency>
<dependency>
<groupId>org.apache.grails.async</groupId>
<artifactId>grails-async-rxjava</artifactId>
<version>${grails.version}</version>
</dependency>
<dependency>
<groupId>org.apache.grails.async</groupId>
<artifactId>grails-async-rxjava2</artifactId>
<version>${grails.version}</version>
</dependency>
... * 100
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
