matrei commented on PR #15245: URL: https://github.com/apache/grails-core/pull/15245#issuecomment-3595837390
Look good @codeconsole. Do we need tests? Some comments below. --- I find the `DisplayType` values a bit unintuitive. Suggestion: ``` DisplayType.ALL -> DisplayType.ALWAYS DisplayType.NONE -> DisplayType.NEVER DisplayType.INPUT_ONLY -> DisplayType.WRITE_ONLY DisplayType.OUTPUT_ONLY -> DisplayType.READ_ONLY ``` --- Aren't the command names and usage instructions inconsistent and confusing (I have not used scaffolding much myself)? When to use `create-*`, `create-scaffold-*` or `generate-*`? I understand this is not caused by this PR, but I think we should overhaul this for Grails 8. Now added to the mix: ```console grails create-scaffold-controller Book grails create-scaffold-service Book grails generate-scaffold-all Book ``` Does `create-scaffold-controller` break compatibility with existing command below? From 7.0.3 `grails help`: | Command | Description | Usage instruction | | --------------- | ----------------- | -------------------------- | | `create-controller` | Creates a controller | `create-controller [controller name]` | | `create-domain-class` | Creates a Domain Class | `create-domain-class [domain class name]` | | `create-scaffold-controller` | Creates a scaffolded controller | `create-controller [controller name]` | | `create-service` | Creates a Service | `create-service [service name]` | | `generate-all` | Generates a controller that performs CRUD operations and the associated views | `grails generate-all [DOMAIN CLASS]` | | `generate-async-controller` | Generates an asynchronous controller that performs CRUD operations | `grails generate-async-controller [DOMAIN CLASS]` | | `generate-controller` | Generates a controller that performs CRUD operations | `grails generate-controller [DOMAIN CLASS]` | | `generate-service` | Generates a Grails data service for the specified domain-class. | No usage instruction | | `generate-views` | Generates GSP views for the specified domain class | `grails generate-views [DOMAIN CLASS]|*` | --- I think it’s a good idea to start removing the `@author` tags, but then we should also refrain from adding new ones. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
