dauer commented on code in PR #15275:
URL: https://github.com/apache/grails-core/pull/15275#discussion_r2606940958


##########
grails-data-hibernate5/docs/src/docs/asciidoc/gettingStarted/outsideGrails.adoc:
##########
@@ -17,21 +17,21 @@ specific language governing permissions and limitations
 under the License.
 ////
 
-If you wish to use GORM for Hibernate outside of a Grails application you 
should declare the necessary dependencies for GORM and the database you are 
using, for example in Gradle:
+If you wish to use GORM for Hibernate outside a Grails application you should 
declare the necessary dependencies for GORM and the database you are using, for 
example in Gradle:
 
 [source,groovy,subs="attributes"]
 ----
-compile "org.apache.grails.data:grails-data-hibernate5-core:{version}"
-runtime "com.h2database:h2:1.4.192"
-runtime "org.apache.tomcat:tomcat-jdbc:8.5.0"
-runtime "org.apache.tomcat.embed:tomcat-embed-logging-log4j:8.5.0"
-runtime "org.slf4j:slf4j-api:1.7.10"
+implementation platform("org.apache.grails:grails-bom:{version}")
+implementation "org.apache.grails.data:grails-data-hibernate5-core"
+runtimeOnly "com.h2database"
+runtimeOnly "org.apache.tomcat:tomcat-jdbc"
+runtimeOnly "org.slf4j:slf4j-nop"

Review Comment:
   I just picked the bare minimum - using `api` is probably a better choise, 
for a more realistic example.
   I wrote a short example for testing, and added `nop` to get rid of this 
message:
   ```
   > Task :Main.main()
   SLF4J(W): No SLF4J providers were found.
   SLF4J(W): Defaulting to no-operation (NOP) logger implementation
   SLF4J(W): See https://www.slf4j.org/codes.html#noProviders for further 
details.
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to