jdaugherty commented on code in PR #15266:
URL: https://github.com/apache/grails-core/pull/15266#discussion_r2623846010
##########
grails-datamapping-validation/src/main/groovy/grails/gorm/validation/Constrained.groovy:
##########
@@ -88,9 +88,16 @@ interface Constrained {
*/
boolean isUrl()
/**
- * @return Whether the value should be displayed
+ * @return Whether the value should be displayed (for backwards
compatibility)
+ * @deprecated Use {@link #getDisplayType()} instead for more granular
control
*/
boolean isDisplay()
+
+ /**
+ * @return The display type controlling where this property is shown in
scaffolded views
+ * @since 7.1
+ */
+ DisplayType getDisplayType()
Review Comment:
@sbglasius I think the real concern is this being a breaking change across
domain objects for 7.x.
If you have your plugin with a domain class on 7.0.4, and you have your
application on 7.1, what happens when you call
`findConstrainedProperties(Holders.grailsApplication.mappingContext.getPersistentEntity(MyDomain.class))`
in your application? If it works, this isnt' a breaking change, if it
doesn't, it is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
