matrei commented on code in PR #15295:
URL: https://github.com/apache/grails-core/pull/15295#discussion_r2626084147


##########
grails-gradle/plugins/src/main/groovy/org/grails/gradle/plugin/web/GrailsWebGradlePlugin.groovy:
##########
@@ -46,19 +44,25 @@ class GrailsWebGradlePlugin extends GrailsGradlePlugin {
         super(registry)
     }
 
-    @CompileDynamic
     @Override
     void apply(Project project) {
         super.apply(project)
-
-        TaskContainer taskContainer = project.tasks
-        if (taskContainer.findByName('urlMappingsReport') == null) {
-            FileCollection fileCollection = buildClasspath(project, 
project.configurations.runtimeClasspath, project.configurations.console)
-            taskContainer.create('urlMappingsReport', 
ApplicationContextCommandTask) {
-                classpath = fileCollection
-                systemProperty(Environment.KEY, 
System.getProperty(Environment.KEY, Environment.DEVELOPMENT.getName()))
-                command = 'url-mappings-report'
-            }
+        project.tasks.register('urlMappingsReport', 
ApplicationContextCommandTask) { task ->

Review Comment:
   @jdaugherty Yes, you are right. I was not aware of this factory loading. 
I'll update the PR to utilize this functionality instead.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to