codeconsole commented on code in PR #15289: URL: https://github.com/apache/grails-core/pull/15289#discussion_r2641085491
########## grails-bootstrap/src/main/groovy/grails/codegen/model/DomainFieldModifier.groovy: ########## @@ -0,0 +1,347 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * https://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package grails.codegen.model + +import groovy.transform.CompileStatic +import org.codehaus.groovy.ast.ClassNode +import org.codehaus.groovy.ast.FieldNode +import org.codehaus.groovy.ast.ModuleNode +import org.codehaus.groovy.ast.PropertyNode +import org.codehaus.groovy.control.CompilationUnit +import org.codehaus.groovy.control.CompilerConfiguration +import org.codehaus.groovy.control.Phases + +import java.nio.charset.StandardCharsets +import java.nio.file.Files + +/** + * Utility class for modifying domain class source files to add fields. + * + * @since 7.0 + */ +@CompileStatic +class DomainFieldModifier { Review Comment: the `grails.codegen.model` package is in grails-bootstrap. This is adding those 2 generation classes to this package that already exists. This needs to be shared across BOTH clis and profiles. grails-bootstrap is already a dependency of grails-shell-cli, putting the classes there means: - profiles can use it (via shell-cli → bootstrap) - shell-cli can use it (already depends on bootstrap) - forge-cli can use it (just needs to depend on bootstrap which is part of this PR) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
