jdaugherty commented on code in PR #15307:
URL: https://github.com/apache/grails-core/pull/15307#discussion_r2690711940
##########
grails-forge/grails-forge-core/src/main/resources/gsp/main.gsp:
##########
@@ -1,81 +1,86 @@
<!doctype html>
-<html lang="en" class="no-js">
+<html lang="en">
<head>
- <meta http-equiv="Content-Type" content="text/html; charset=UTF-8"/>
- <meta http-equiv="X-UA-Compatible" content="IE=edge"/>
- <title>
- <g:layoutTitle default="Grails"/>
- </title>
+ <meta charset="utf-8"/>
<meta name="viewport" content="width=device-width, initial-scale=1"/>
+ <title><g:layoutTitle default="Grails"/></title>
<asset:link rel="icon" href="favicon.ico" type="image/x-ico"/>
<asset:stylesheet src="application.css"/>
<g:layoutHead/>
</head>
<body>
-<nav class="navbar navbar-expand-lg bg-body-tertiary">
- <div class="container-fluid">
- <a class="navbar-brand" href="/#"><asset:image class="w-75"
src="grails.svg" alt="Grails Logo"/></a>
- <button class="navbar-toggler" type="button" data-bs-toggle="collapse"
data-bs-target="#navbarContent" aria-controls="navbarSupportedContent"
aria-expanded="false" aria-label="Toggle navigation">
- <span class="navbar-toggler-icon"></span>
- </button>
-
- <div class="collapse navbar-collapse" aria-expanded="false"
id="navbarContent">
- <ul class="navbar-nav">
- <g:pageProperty name="page.nav"/>
- </ul>
- </div>
+<nav class="navbar navbar-expand-lg bg-body border-bottom shadow-sm">
+ <div class="container-lg">
+ <a class="navbar-brand d-flex align-items-center"
href="${request.contextPath}/">
+ <asset:image class="w-75" src="grails.svg" alt="Grails Logo"/>
+ </a>
</div>
</nav>
-<g:layoutBody/>
+<div class="bg-body-tertiary">
+ <div class="container-lg py-4">
+ <g:layoutBody/>
+ </div>
+</div>
-<div class="footer" role="contentinfo">
- <div class="container-fluid">
- <div class="row">
- <div class="card border-0 col-12 col-md">
- <div class="card-body">
- <h6 class="card-title">
- <a class="link-underline link-underline-opacity-0"
href="https://guides.grails.org"; target="_blank">
- <asset:image src="advancedgrails.svg" alt="Grails
Guides" class="me-2" width="34" />Grails Guides
- </a>
- </h6>
- <p class="card-text">Building your first Grails app?
Looking to add security, or create a Single-Page-App? Check out the <a
href="https://guides.grails.org"; target="_blank">Grails Guides</a> for
step-by-step tutorials.</p>
- </div>
+<footer class="border-top py-5" role="contentinfo">
+ <div class="container-lg">
+ <div class="row g-4">
+ <div class="col-12 col-md-4">
+ <a class="card h-100 text-decoration-none shadow-sm border-1"
+ href="https://guides.grails.org"; target="_blank"
rel="noopener">
+ <div class="card-body p-4">
+ <div class="d-flex align-items-center
justify-content-between mb-2">
+ <h6 class="card-title mb-0 fw-semibold">Grails
Guides</h6>
+ <asset:image src="advancedgrails.svg" alt="Grails
Guides" width="34" height="34"/>
+ </div>
+ <p class="card-text text-body-secondary mb-0">
+ Building your first Grails app? Looking to add
security, or create a Single-Page-App?
+ Check out the Grails Guides for step-by-step
tutorials.
+ </p>
+ </div>
+ </a>
</div>
- <div class="card border-0 col-12 col-md">
- <div class="card-body">
- <h6 class="card-title">
- <a class="link-underline link-underline-opacity-0"
href="https://grails.apache.org/docs/"; target="_blank">
- <asset:image src="documentation.svg" alt="Grails
Documentation" class="me-2" width="34" />Documentation
- </a>
- </h6>
- <p class="card-text">Ready to dig in? You can find
in-depth documentation for all the features of Grails in the <a
href="https://grails.apache.org/docs/"; target="_blank">User Guide</a>.</p>
- </div>
+ <div class="col-12 col-md-4">
+ <a class="card h-100 text-decoration-none shadow-sm border-1"
+ href="https://grails.apache.org/docs/"; target="_blank"
rel="noopener">
+ <div class="card-body p-4">
+ <div class="d-flex align-items-center
justify-content-between mb-2">
+ <h6 class="card-title mb-0
fw-semibold">Documentation</h6>
+ <asset:image src="documentation.svg" alt="Grails
Documentation" width="34" height="34"/>
+ </div>
+ <p class="card-text text-body-secondary mb-0">
+ Ready to dig in? You can find in-depth
documentation for all the features
+ of Grails in the User Guide.
+ </p>
+ </div>
+ </a>
</div>
- <div class="card border-0 col-12 col-md">
- <div class="card-body">
- <h6 class="card-title">
- <a class="link-underline link-underline-opacity-0"
href="https://slack.grails.org"; target="_blank">
- <asset:image src="slack.svg" alt="Grails Slack"
class="me-2" width="34" />Join the Community
- </a>
- </h6>
- <p class="card-text">Get feedback and share your
experience with other Grails developers in the community <a
href="https://slack.grails.org"; target="_blank">Slack channel</a>.</p>
- </div>
+ <div class="col-12 col-md-4">
+ <a class="card h-100 text-decoration-none shadow-sm border-1"
+ href="https://slack.grails.org"; target="_blank"
rel="noopener">
+ <div class="card-body p-4">
+ <div class="d-flex align-items-center
justify-content-between mb-2">
+ <h6 class="card-title mb-0 fw-semibold">Join the
Community</h6>
+ <asset:image src="slack.svg" alt="Grails Slack"
width="34" height="34"/>
Review Comment:
Should we reference the mailing lists, github, & slack?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
