jdaugherty commented on PR #15320: URL: https://github.com/apache/grails-core/pull/15320#issuecomment-3774041102
> > So it looks like the exclusions added to grails-gsp are now being properly applied. The side effect is several of the libraries that are included by Gradle are not being included when using spring dependency management plugin. > > These appear the ones needed under grails-gsp: > > ``` > > 1. grails-encoder exports groovy-json > > > > 2. grails-web-common exports spring-webmvc > > ``` > > > > > > > > > > > > > > > > > > > > > > > > Removing the excludes fixes the interceptor tests. I suspect we'll find more as we test. > > I'm not sure this is the right solution. > > Why is it the responsibility of `grails-encoder` to provide `groovy-json` via `grails-gsp`, even though it is not used in `grails-gsp` API scope? And why is it the responsibility of `grails-gsp` to provide `spring-webmvc` from `grails-web-common`? > > What if the application does not use the GSP plugin? > > I think we can do this workaround for now, but keep the exclusions (commented out) with a comment explaining why they are not excluded. I'll add that change for review. I think the original intent was web-common would provide common web libraries, but we've added excludes. We definitely have the various dependency "starters" that say we provide them. It seems that gsp or the gson projects are where these have historically come from. We need to revisit on what we exclude; we don't want end apps having to include some of these lower libraries. All of the gsp projects need re-architected to make it clear what's being provided where. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
