jamesfredley commented on code in PR #15429: URL: https://github.com/apache/grails-core/pull/15429#discussion_r2836202981
########## grails-datamapping-tck/src/main/groovy/org/apache/grails/data/testing/tck/domains/DataServiceRoutingProduct.groovy: ########## @@ -0,0 +1,39 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * https://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.grails.data.testing.tck.domains + +import grails.gorm.annotation.Entity +import org.grails.datastore.gorm.GormEntity + +@Entity +class DataServiceRoutingProduct implements GormEntity<DataServiceRoutingProduct> { + + Long id + Long version + String name + Integer amount + + static mapping = { + datasource 'ALL' + } + + static constraints = { + name blank: false Review Comment: Good catch. Added `amount nullable: false` for consistency with `WhereRoutingItem`. Fixed in 44ff9cc. ########## grails-datamapping-tck/src/main/groovy/org/apache/grails/data/testing/tck/tests/DataServiceConnectionRoutingSpec.groovy: ########## @@ -0,0 +1,292 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * https://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.grails.data.testing.tck.tests + +import spock.lang.Issue +import spock.lang.Requires + +import org.grails.datastore.gorm.GormEnhancer + +import org.apache.grails.data.testing.tck.base.GrailsDataTckSpec +import org.apache.grails.data.testing.tck.domains.DataServiceRoutingProduct +import org.apache.grails.data.testing.tck.domains.DataServiceRoutingProductDataService +import org.apache.grails.data.testing.tck.domains.DataServiceRoutingProductService + +@Issue('https://github.com/apache/grails-core/issues/15394') Review Comment: Correct - #15394 is about scaffolding Geb tests, not Data Service routing. PR #15395 was filed directly as a fix without a corresponding issue, so removed the `@Issue` annotation entirely. Fixed in 44ff9cc. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
