jdaugherty commented on code in PR #15478: URL: https://github.com/apache/grails-core/pull/15478#discussion_r2918513231
########## grails-testing-support-core/src/main/groovy/grails/testing/spring/IntegrationTestAutoConfiguration.groovy: ########## @@ -0,0 +1,51 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * https://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package grails.testing.spring + +import java.lang.annotation.ElementType +import java.lang.annotation.Retention +import java.lang.annotation.RetentionPolicy +import java.lang.annotation.Target + +import org.springframework.boot.test.context.TestConfiguration + +/** + * Marker annotation for Spring test configuration classes that should be auto-imported into + * Integration tests by {@code IntegrationTestAstTransformation}. + * + * @since 7.1 + */ +@Retention(RetentionPolicy.RUNTIME) +@Target([ElementType.TYPE]) +@TestConfiguration(proxyBeanMethods = false) +@interface IntegrationTestAutoConfiguration { Review Comment: So instead of a spock extension, you went with the bean approach. I assume that's why this change is now for 7.1.x instead of 7.0.x? I don't think it's a problem to use the test configuration approach, but can you give background on what led you down this path? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
