vigneshsiva11 commented on PR #15566: URL: https://github.com/apache/grails-core/pull/15566#issuecomment-4229736254
Hi @jdaugherty and @jamesfredley I want to thank you for taking the time to review my work and for the guidance you provided. I made some changes to this PR based on the feedback you gave me. I removed the annotation processor wiring from the modules that are focused on Groovy. I also made sure that the scope of this change is narrow and only includes databinding for now, which is what we are calling Phase 1. This change should help with the issue of incremental compilation, and it keeps this PR small and easy to review. I went ahead. Pushed the updated commit. Then I checked the builds again to ensure everything is working correctly after I made these changes. If this PR is still getting in the way of the work that @jamesfredley is doing, then I am more than happy to make some adjustments or even close this PR if that is what you would prefer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
