jamesfredley commented on code in PR #25:
URL:
https://github.com/apache/grails-gradle-publish/pull/25#discussion_r3126556003
##########
plugin/build.gradle:
##########
@@ -27,10 +27,10 @@ group = 'org.apache.grails.gradle'
dependencies {
// compile grails-gradle-plugin with the Groovy version provided by Gradle
- // to ensure build compatibility with Gradle, currently Groovy 3.0.x
+ // to ensure build compatibility with Gradle, currently Groovy 4.0.x
// see: https://docs.gradle.org/current/userguide/compatibility.html#groovy
- api platform("org.codehaus.groovy:groovy-bom:${GroovySystem.version}")
- compileOnly 'org.codehaus.groovy:groovy'
+ api platform("org.apache.groovy:groovy-bom:${GroovySystem.version}")
Review Comment:
Good catch, applied in
[4122d4b](https://github.com/apache/grails-gradle-publish/commit/4122d4bd0c2a78d39abf43daf69c61e69dd0bbc1).
I verified the effect by re-running `./gradlew
publishPluginMavenPublicationToTestCaseMavenRepoRepository` and diffing the
generated POM:
- **Before** (`api platform(...)`): the POM contained a
`<dependencyManagement>` block importing `org.apache.groovy:groovy-bom:4.0.29`,
pinning consumers to the build-time Groovy version.
- **After** (`compileOnly platform(...)`): the `<dependencyManagement>`
block is gone; the BOM constraint is scoped to `compileClasspath` only and is
not published.
Full build stays green on Java 17 and Java 21 (44/44 tests pass).
##########
gradle/test-config.gradle:
##########
@@ -41,11 +41,11 @@ import org.gradle.api.plugins.jvm.JvmTestSuite
testing {
suites {
test {
- useSpock('2.3-groovy-3.0')
+ useSpock('2.3-groovy-4.0')
Review Comment:
Done in
[7294afd](https://github.com/apache/grails-gradle-publish/commit/7294afd).
`2.4-groovy-4.0` is the latest stable Spock release (2025-12-11) and the
current recommended baseline on Groovy 4. No spec changes were needed - all 44
tests pass unchanged on both Java 17 and Java 21.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
