jamesfredley commented on PR #15598:
URL: https://github.com/apache/grails-core/pull/15598#issuecomment-4312633360
@matrei @copilot-pull-request-reviewer new commit `5037a40` - heads up, the
PR has expanded in scope, your prior approval is stale:
- โ
@matrei: reworked the inline comment to describe the root cause instead
of naming `8.0.0-SNAPSHOT`.
- โ
@copilot: `Upload Wrapper Zip` step's `path: tmp/wrapper` is repo-root
relative but the zip actually lands under `build/tmp/wrapper`. Apr 2's
successful run confirmed it: `##[warning]No files were found with the provided
path: tmp/wrapper. No artifacts will be uploaded.` Fixed to `build/tmp/wrapper`.
- ๐ End-user scenario: the wrapper README ("Creating a Grails Application" -
extract to empty dir, `export PREFERRED_GRAILS_VERSION=...`, `grailsw -t forge
create-app`) hits the same latent bug because `PREFERRED_GRAILS_VERSION` is
dead code in `GrailsVersion#getPreferredGrailsVersion` - only consulted inside
an unreachable branch. Reworked the precedence to match the README
(gradle.properties inside a project wins; env var outside a project is
honoured), extracted a package-private overload for testability, and added 5
Spock tests covering the precedence matrix.
- ๐งน With the env var now functional, the CI step `export
PREFERRED_GRAILS_VERSION=...` is cleaner than writing a `gradle.properties`
into `build/`.
All 12 `:grails-wrapper:test` specs pass locally (7 existing + 5 new).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
