jamesfredley commented on PR #15365: URL: https://github.com/apache/grails-core/pull/15365#issuecomment-4312911760
## Round of review feedback addressed **Telemetry override (your top-level comment):** swapped the `opentelemetry-bom` platform import for an explicit list of constraints on the individual `io.opentelemetry:opentelemetry-*` modules in `dependencies.gradle` / `grails-bom/build.gradle`. Explicit constraints win over any imported BOM's transitively-managed version, so this no longer relies on platform import ordering (same class of issue you hit on the hibernate PR). **`grails-publish` 0.0.4 -> 1.0.0-SNAPSHOT:** consume the new Gradle 9 / Java 21 build of the publish plugin. Added the apache snapshots repo to the root, `grails-gradle`, and `grails-gradle/buildSrc` `pluginManagement` blocks so the composite build classpath can resolve the snapshot before `org.apache.grails.buildsrc.repo` itself is loaded (chicken-and-egg with the existing `includeBuild`-only pluginManagement). Companion PR: apache/grails-gradle-publish#25. **Inline review threads (all 20 resolved):** see individual replies on each thread. Every prior unresolved item is now either confirmed already in place or fixed in the new commit: * `grails-forge` `micronaut-inject-groovy` and `jackson-databind` -> serde-jackson via the BOM (5 forge build files + `test-core` + `analytics-postgres`) * `grails-forge/gradle.properties` `groovyVersion` 4.0.30 -> 4.0.31 * `grails-bom/build.gradle` java-platform plugin guard removed (per your guidance the task is internal-only) * `grails-doc/build.gradle` per-project `groovydoc` task disabled (no real source to document) instead of adding a `dist` dependency on it * `gradle.properties` `micronautHttpClientVersion` / `micronautSerdeJacksonVersion` removed; `grails-test-examples-micronaut` now uses the micronaut-platform BOM * `Application Properties.adoc` reverted out of this PR (will submit separately) **Latest 8.0.x merged in:** picked up the Jansi/JLine upgrade (#15367), forge GraalVM image fixes (#15579, #15580), pull request template, and 7.1.0 release. One conflict in `dependencies.gradle` resolved by keeping the gradle-9 versions (`gradle-spock 2.3-groovy-4.0`, `gradle-groovy 4.0.31`, `grails-publish 1.0.0-SNAPSHOT`) and 8.0.x's `jansi 2.4.2`. Locally verified `./gradlew :grails-bom:extractConstraints` and `./gradlew :grails-test-examples-scaffolding:validateDependencyVersions` both pass on Java 21+ after the merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
