jdaugherty commented on code in PR #15621: URL: https://github.com/apache/grails-core/pull/15621#discussion_r3178435481
########## etc/bin/verify-branch.sh: ########## @@ -0,0 +1,349 @@ +#!/usr/bin/env bash +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# https://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# +# verify-branch.sh - pre-tag release readiness check +# +# Runs all release-readiness checks that can be done LOCALLY against the +# current working tree, with no tag, no GitHub release, and no staged +# artifacts. This is the pre-tag counterpart to verify.sh. +# +# Use this BEFORE publishing the release tag (e.g. v8.0.0-M1) to gain +# confidence that the publish job in .github/workflows/release.yml will +# succeed. After staging completes, use the existing verify.sh to verify +# the staged artifacts themselves. +# +# Recommended usage on the 8.0.x branch: +# +# etc/bin/verify-branch.sh +# +# Or inside the verification container (recommended for parity with CI): +# +# docker build -t grails:testing -f etc/bin/Dockerfile . +# docker run -it --rm -v "$(pwd):/home/groovy/project" grails:testing bash +# cd /home/groovy/project +# etc/bin/verify-branch.sh + +set -euo pipefail + +usage() { + cat <<'EOF' +Usage: verify-branch.sh [OPTIONS] + +Runs the release-readiness checks that can be performed locally against the +current working tree, without requiring a tag, GitHub release, or any staged +artifacts. Mirrors the locally-runnable surface of release.yml's publish job. + +Default checks (typically 15-30 minutes): Review Comment: I think you responded to the parent comment instead of the suggestion to add the validation dependency task. As for smoke testing, isn't this only an issue once we create major branches? I'm trying to point out that the benefit to having another script isn't greater than the cost to maintain 2 separate pieces of logic. Plus, you ultimately still can have the workflow fail b/c of environmental configuration. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
