kirpi4ik commented on PR #15587: URL: https://github.com/apache/grails-core/pull/15587#issuecomment-4371150474
> ... > ## Left open for direction > * **[Backport Grails Bom Restructure from Hibernate 7 branch #15605](https://github.com/apache/grails-core/pull/15605) BOM tracker** (`gradle.properties` versions, `graphql-java` version pin in `plugin/build.gradle`) - 3 threads. Will move once the BOM-restructure backport lands on `7.2.x`. > * **`GraphqlController.browser()` / `GraphqlControllerSpec`** - 2 threads. The browser action is currently a no-op (returns 404 unless the host app supplies its own `graphiql.html`). Happy to keep it (current state) or remove it entirely - waiting on your call. > * **`HibernatePersistentGraphQLPropertySpec` ordering shift** - 1 thread. Expected values genuinely shifted on Grails 7 GORM but I haven't pinned down the upstream cause yet. Open to digging deeper or reverting. ... > ``` - Moved both `graphql-java` and `graphql-java-extended-scalars` to the bom, the last one also added because it depends on specific version of graphql so it would make sense to keep them in the same place but let me know if we should remove the scalar. - For the `GraphqlController.browser()` - I think we should keep as-is, the 404 fallback is harmless, host apps can supply their own customized graphiql.html - For `HibernatePersistentGraphQLPropertySpec` - Replayed above https://github.com/apache/grails-core/pull/15587#discussion_r3181498564 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
