jdaugherty commented on PR #15568: URL: https://github.com/apache/grails-core/pull/15568#issuecomment-4426634140
@matrei & @jamesfredley if we can agree to this second point: the mass change in the TCK from manager.domainClasses.addAll to manager.addAllDomainClasses made this a lot harder to review. I would have preferred we did this in a separate PR. We may want to revert that change in mass to significantly reduce this PR size. The same goes for the package move & the new base class in the Mongo classes. We can easily do both of these in the stage PR to reduce this one. If @jamesfredley & @matrei agree, I think we should move these to the stage PR so this PR will be reduced by 600+ files. Then we can significantly reduce the required files to review on this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
