jdaugherty commented on code in PR #15568:
URL: https://github.com/apache/grails-core/pull/15568#discussion_r3229935607
##########
grails-datamapping-tck/src/main/groovy/org/apache/grails/data/testing/tck/tests/OptimisticLockingSpec.groovy:
##########
@@ -59,67 +64,132 @@ class OptimisticLockingSpec extends GrailsDataTckSpec {
o.version == 1
}
- // hibernate has a customized version of this
- @IgnoreIf({ System.getProperty('hibernate5.gorm.suite') ||
System.getProperty('hibernate7.gorm.suite') })
+ @IgnoreIf({ System.getProperty('mongodb.gorm.suite') == 'true' })
void "Test optimistic locking"() {
given:
def o = new OptLockVersioned(name: 'locked').save(flush: true)
manager.session.clear()
+ manager.transactionManager.commit manager.transactionStatus
Review Comment:
This breaks everything except hibernate. I think we need to revisit this
class - the tck version should probably be the origianl value and the hibernate
version should have these more detailed settings. @borinquenkid can you take a
look at this one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
