jamesfredley commented on PR #15684: URL: https://github.com/apache/grails-core/pull/15684#issuecomment-4564878907
I agree with standardizing on parentheses for method calls. It is the majority, but separate from this we will need to create a issue to go back to cleanup. on `origin/8.0.x` (the PR's actual base = historical truth) Combined `eq` + `like`: | Scope | paren | no-paren | split | |-------|------:|------:|:-----:| | All `.groovy` | **109** (92 + 17) | 97 (77 + 20) | ~53 / 47 | | `*Spec.groovy` only | **94** (79 + 15) | 78 (69 + 9) | ~55 / 45 | Per-method breakdown: | Method / scope | paren | no-paren | |---|------:|------:| | `eq` - all groovy | **92** | 77 | | `eq` - specs only | **79** | 69 | | `like` - all groovy | 17 | **20** | | `like` - specs only | **15** | 9 | ## Staging vs base (specs only) | Branch | paren | no-paren | |---|------:|------:| | `8.0.x` (base, historical truth) | **94** | 78 | | `8.0.x-stage-hibernate7` (staging) | 95 | 88 | The staging branch added ~10 no-paren spec lines on top of base. The migration toward no-paren is something the hibernate7 staging work itself introduced, not a pre-existing house style. ## Verdict - Historically on `8.0.x`, the **parenthesized form is the plurality** - roughly 55/45 in specs, 53/47 overall. - `eq(...)` specifically leads in every slice (92 vs 77 overall, 79 vs 69 in specs). - The only place no-paren wins is `like` across all groovy (20 vs 17), and that flips back to paren when restricted to specs (15 vs 9). - The `HibernateCriteriaBuilder` javadoc examples and most example/integration-test apps use the parenthesized form. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
