sbglasius commented on code in PR #15700:
URL: https://github.com/apache/grails-core/pull/15700#discussion_r3322953422
##########
grails-datastore-core/src/main/groovy/org/grails/datastore/mapping/config/groovy/DefaultMappingConfigurationBuilder.groovy:
##########
@@ -47,7 +47,11 @@ class DefaultMappingConfigurationBuilder implements
MappingConfigurationBuilder
Map<String, Property> getProperties() {
if (!target.propertyConfigs.isEmpty()) {
- properties.putAll(target.propertyConfigs)
+ for (Map.Entry entry : target.propertyConfigs.entrySet()) {
+ if (!properties.containsKey(entry.key)) {
+ properties.put(entry.key, entry.value)
+ }
Review Comment:
Would it make sense to make a log statement if the `properties` actually
contains the `entry` and that way give the developer a chance to know that
there is a conflicting property?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
