jamesfredley commented on PR #15558: URL: https://github.com/apache/grails-core/pull/15558#issuecomment-4580366132
## Verified against a real Groovy-6 Spock ([spockframework/spock#2363](https://github.com/spockframework/spock/pull/2363)) Confirmed locally that this canary builds and its tests pass against a genuine Groovy-6 Spock build - i.e. the eventual exit path for the `disableGroovyVersionCheck` bridge (remaining workaround #1) works. **Local verification only; nothing committed.** **Setup** - Built spock PR #2363 (`groovy-6-canary`, "[Canary] Add Groovy 6 support"; its `variantsList` now includes `6.0`) and published to mavenLocal: `./gradlew -Dvariant=6.0 -DjavaVersion=21 :spock-core:publishToMavenLocal :spock-spring:publishToMavenLocal :spock-bom:publishToMavenLocal` → `org.spockframework:{spock-core,spock-spring,spock-bom}:2.5-groovy-6.0-SNAPSHOT` (built against groovy `6.0.0-alpha-1`; grails-core overrides the runtime groovy to its `6.0.0-SNAPSHOT`). - Temporarily enabled `mavenLocal()` and set `spock.version = 2.5-groovy-6.0-SNAPSHOT` (both reverted afterwards). **Results** - both ran on `Spock 2.5.0-groovy-6.0-SNAPSHOT` (confirmed in the logs): - `:grails-core:test` - 309 unit Spock specs, **BUILD SUCCESSFUL**. - `:grails-test-examples-external-configuration:test` - full Grails app + Spock functional specs, **BUILD SUCCESSFUL**. **One caveat worth recording:** the `Executing Spock ... NOT compatible Groovy version 6.0.0-SNAPSHOT` warning still prints, because Spock 2.5-groovy-6.0's version check treats the pre-release `6.0.0-SNAPSHOT` as *below* its `6.0.0` minimum. So while this branch tracks a Groovy **snapshot**, the `disableGroovyVersionCheck` flag is still required even with the real Groovy-6 Spock; it should drop once we build against a Groovy 6.0.0 **release** (or once Spock's check accepts the snapshot). The transform itself is correct - all specs compile and pass. **Takeaway:** once a `spock-*-groovy-6.0` artifact is published, adopting it here is a one-line `spock.version` bump (the Sonatype Central snapshot repo is already wired in `settings.gradle`), and the suite stays green. Assisted-by: claude-code:claude-4.8-opus -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
