The GitHub Actions job "CI - Groovy Joint Validation Build" on grails-core.git/8.0.x-hibernate7.gorm-scaling-clean has failed. Run started by GitHub user borinquenkid (triggered by borinquenkid).
Head commit for run: 39eadadf0069853e1ea9700c438a45f54be6964d / Walter Duque de Estrada <[email protected]> fix: resolve functional-test regressions from the O(M+N) GORM rewrite Fixes five of the six failing Functional Tests CI tasks. Each was a core GORM contract that regressed in the shared-GormRegistry rewrite but surfaced far downstream; root-cause fixes are guarded by core unit tests. - SimpleMapSession: a rolled-back transaction set a session-level rollbackOnly flag that was never cleared, permanently turning flush() into a no-op on the (long-lived, thread-bound) test session. Subsequent save(flush:true) calls assigned an id and populated the first-level cache but never reached the backing map. Clear the marker on commit/rollback and reset it when a transaction begins. Adds SimpleMapSessionSpec coverage. Fixes the app1 BookControllerSpec save/delete count()==0 failures. - DataTest harness: the single shared GormRegistry resolves a domain mapped to a non-default datasource to a dedicated per-connection child datastore, but the unit-test interceptors only bound a session for the default datastore. Entities on non-default datasources ran in throwaway per-call sessions, so save() without an explicit flush was lost before an auto-flushing query. Bind (and symmetrically unbind) a session for every connection source; no-op for single-datasource specs. Adds NonDefaultDatasourceFlushSpec. Fixes demo33 CarSpec. - GormStaticApi.withTransaction(Map)/withNewTransaction(Map): replaced the broken definition.setProperty(key, value) call (no such method on the Java bean DefaultTransactionDefinition) with the property-set idiom definition[key]=value, plus CharSequence coercion and a clear error for unknown properties. Fixes CrossDatasourceTransactionSpec read-only transactions. - DefaultHalViewHelper: reverted the embedded-version exclusion. Embedded HAL output renders the version property for versioned entities (functional TeamSpec depends on it); the unit-level HalEmbeddedSpec only saw an extra version:0 because KeyValue entities now auto-map a version under the GORM mapping strategy, so its expectation is updated instead. - demo33 UniqueConstraintOnHasOneSpec: removed a stale @NotYetImplemented (a second copy of an already-fixed spec) that fails as "passes unexpectedly". - Bar/FooIntegrationSpec: assert datastore persistence through public, observable behavior (Mongo ObjectId / Hibernate sequential id) instead of the removed internal org.grails.datastore.gorm.GormEnhancer.findStaticApi probe. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]> Report URL: https://github.com/apache/grails-core/actions/runs/26664582995 With regards, GitHub Actions via GitBox
