jamesfredley commented on code in PR #15557:
URL: https://github.com/apache/grails-core/pull/15557#discussion_r3337498104
##########
build-logic/plugins/src/main/groovy/org/apache/grails/buildsrc/CompilePlugin.groovy:
##########
@@ -114,6 +115,9 @@ class CompilePlugin implements Plugin<Project> {
it.options.compilerArgs += ['-Xlint:-removal']
}
}
+ project.tasks.withType(Test).configureEach {
+
it.jvmArgs('-Dspock.iKnowWhatImDoing.disableGroovyVersionCheck=true')
Review Comment:
Removed entirely. The released `spock-core 2.4-groovy-5.0` accepts the
`[5.0.0, 5.9.99]` Groovy window (its `VersionChecker`/`SpockReleaseInfo`), and
`5.0.7-SNAPSHOT` parses inside it, so the check never actually fired on the
snapshot. Confirmed against the Spock source and empirically:
`:grails-bootstrap:test` (ConfigMapSpec) and `:grails-validation:test`
(concrete-class mocking) both pass with `disableGroovyVersionCheck` fully
removed from `CompilePlugin`, `test-config.gradle` and
`functional-test-config.gradle`. The redundant per-module byte-buddy/objenesis
double-adds were dropped too.
##########
grails-test-examples/app1/build.gradle:
##########
@@ -92,5 +92,6 @@ test {
apply {
from
rootProject.layout.projectDirectory.file('gradle/functional-test-config.gradle')
from
rootProject.layout.projectDirectory.file('gradle/test-webjar-asset-config.gradle')
+ from
rootProject.layout.projectDirectory.file('gradle/boot4-disabled-integration-test-config.gradle')
Review Comment:
`integrationTest` is disabled here by two known blockers, not a hidden build
failure: (a) the Groovy 5 + `-PgrailsIndy=false` controller-action
parameter-scope regression and (b) SiteMesh3's incompatibility with Spring 7.
The functional tests (indy=true) for these apps still pass, so the application
code is exercised. This is documented as remaining workaround #2 in the
description; each module's `integrationTest` will be re-enabled as its blocker
is fixed.
##########
gradle/boot4-disabled-integration-test-config.gradle:
##########
@@ -15,13 +15,31 @@
* limitations under the License.
*/
-// TODO: BOOT4 - Integration tests disabled due to Spring Boot 4
incompatibilities.
+// TODO: BOOT4 / GROOVY5 - Integration tests disabled due to known regressions.
//
// Modules applying this file have their integrationTest task disabled because
of
-// external plugin/library incompatibilities with Spring Boot 4 / Spring
Framework 7.
+// known incompatibilities that the PR has not yet fixed. STILL BROKEN -
workaround
+// only. Do NOT remove this apply without verifying each affected module's
tests pass
+// on Groovy 5.0.x with -PgrailsIndy=false.
//
// Known blockers:
-// - SiteMesh3: Decorator/layout not compatible with Spring Framework 7
+// - SiteMesh3: Decorator/layout not compatible with Spring Framework 7.
+// - Groovy 5 + indy=false: Controller action methods that declare parameters
Review Comment:
Yes - re-verified against the current `5.0.7-SNAPSHOT` (`GROOVY_5_0_X` HEAD,
2026-06-01). Both blockers still reproduce: the controller-action
parameter-scope NPE under `-PgrailsIndy=false` and the SiteMesh3/Spring 7
incompatibility. The comment has been condensed to just those two blockers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
