jamesfredley commented on PR #15686: URL: https://github.com/apache/grails-core/pull/15686#issuecomment-4596988064
Dialed this PR back to its intended scope based on the review feedback. Pushed three focused commits: **1. Limit `grails-code-analysis` to its original scope** (`6d79c8addc`) Removed the `grails-code-analysis` (PMD + SpotBugs) plugin application from all 96 subprojects. The convention plugin stays registered in `build-logic` as available infrastructure - it is just applied nowhere on this branch. On why it is zero and not "3 subprojects": tracing the Hibernate 7 branch history, the analysis plugin originally ran on a **single** module, `grails-data-hibernate7/core`, before a later commit expanded it project-wide. That module does not exist on `8.0.x` yet (it lives in the Hibernate 7 work this was carved out of), so there is nothing here to apply it to. **When the Hibernate 7 work is merged back in, the analysis plugin will need to be re-hooked up to the relevant `grails-data-hibernate7` module(s).** **2. Restore code style configuration to the 8.0.x baseline** (`b08441587d`) `grails-forge` is now byte-identical to `8.0.x`: its own (more lenient) Checkstyle ruleset and Spotless config are back, and the reformatting of 217 source files is reverted. Changing Forge's styling here was accidental - Forge keeps its separate rule set and its code style job passes as before (verified `:grails-forge-core:spotlessCheck checkstyleMain` green on JDK 21). This commit also: - reverts `createOrLoad()` to the original create-only-if-missing behavior (per @jdaugherty's review), - keeps the legacy `grails.codestyle.dir.*` property-override keys so Forge's custom config dir still resolves (otherwise Forge falls back to the bundled strict ruleset), - points the Forge code-style CI job back at `./gradlew codeStyle` (Forge no longer applies the violation-aggregation plugin). **3. Fix code-style report path in the violation-aggregation spec** (`3b808a9bb8`) A test was still reading the pre-rename `build/reports/codestyle` location; aligned it with the plugin's `build/reports/code-style` output. Verification: `build-logic:test` passes, the root build configures (JDK 21), and Forge code style passes. Note: `codeanalysis.yml` is intentionally dormant for now (analysis is applied nowhere) and will start producing real reports again once analysis is re-hooked to the Hibernate 7 module(s) on merge-back. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
