bito-code-review[bot] commented on PR #15699:
URL: https://github.com/apache/grails-core/pull/15699#issuecomment-4602669248
<!-- Bito Reply -->
The comment in `DefaultASTDatabindingHelper.java` explains the logic for
filtering inherited properties to prevent `id`, `version`, `dateCreated`, and
`lastUpdated` from being incorrectly bound when a domain class extends an
abstract `@DirtyCheck` base class. While the code is functional, the comment is
indeed quite verbose. You can simplify it to focus on the core intent:
preventing the inheritance of default-excluded domain properties from
non-domain parent classes.
**grails-web-databinding/src/main/groovy/org/grails/web/databinding/DefaultASTDatabindingHelper.java**
```
// Prevent inheritance of default-excluded domain properties (id, version,
etc.)
// from non-domain parent classes (e.g., abstract
@DirtyCheck base classes).
if (isDomainClass &&
DOMAIN_CLASS_PROPERTIES_TO_EXCLUDE_BY_DEFAULT.contains(parentPropertyName)) {
continue;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
