jdaugherty commented on code in PR #15694:
URL: https://github.com/apache/grails-core/pull/15694#discussion_r3341400511
##########
grails-forge/grails-forge-core/src/main/java/org/grails/forge/feature/logging/Logback.java:
##########
@@ -61,17 +60,10 @@ public boolean shouldApply(ApplicationType applicationType,
Options options, Set
@Override
public void apply(GeneratorContext generatorContext) {
- OperatingSystem operatingSystem =
generatorContext.getOperatingSystem();
- boolean jansi = false;
-
- if (operatingSystem != OperatingSystem.WINDOWS) {
Review Comment:
This breaks color logging on other OSs. I don't agree with this solution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
