jdaugherty commented on code in PR #15557:
URL: https://github.com/apache/grails-core/pull/15557#discussion_r3341549544
##########
grails-gradle/gradle/docs-config.gradle:
##########
@@ -25,11 +25,13 @@ dependencies {
// TODO: Remove jline:jline (JLine 2) when upgrading to Groovy 5
(groovy-groovysh 5.x uses JLine 3)
add('documentation', 'jline:jline')
add('documentation', 'com.github.javaparser:javaparser-core')
- add('documentation',
"org.apache.groovy:groovy:${bomDependencyVersions['groovy.version']}")
- add('documentation',
"org.apache.groovy:groovy-groovydoc:${bomDependencyVersions['groovy.version']}")
- add('documentation',
"org.apache.groovy:groovy-ant:${bomDependencyVersions['groovy.version']}")
- add('documentation',
"org.apache.groovy:groovy-docgenerator:${bomDependencyVersions['groovy.version']}")
- add('documentation',
"org.apache.groovy:groovy-templates:${bomDependencyVersions['groovy.version']}")
+ // grails-gradle subprojects target Gradle's embedded Groovy 4 (see
gradleBomDependencyVersions['gradle-groovy.version']).
+ // Do NOT use the main Groovy version here - that is Groovy 5.x in Grails
8 and would override the gradle-groovy-bom platform.
Review Comment:
This was just a bug. Let's remove the comment and just reference the
gradleBomDependencyVersions as you've suggested. Or simplify the comment to
indicate use gradle's groovy and not our own.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
