borinquenkid commented on code in PR #15683:
URL: https://github.com/apache/grails-core/pull/15683#discussion_r3343550843
##########
grails-data-mongodb/core/src/test/groovy/org/apache/grails/data/mongo/core/GrailsDataMongoTckManager.groovy:
##########
@@ -126,10 +125,10 @@ class GrailsDataMongoTckManager extends
GrailsDataTckManager {
return null
}
})
- mappingContext.addPersistentEntities(allClasses as Class[])
+ mappingContext.addPersistentEntities(domainClasses as Class[])
Review Comment:
this is really a codesmell from subclassing breaking encapsulation. the
correct structure passed around should be an immutable collection. But I really
want to get out of this branch, the amount of churn here and what we got out of
it is too big IMHO.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
