The GitHub Actions job "CI" on grails-core.git/feature/compileStaticTagLibs has 
succeeded.
Run started by GitHub user jdaugherty (triggered by jdaugherty).

Head commit for run:
58acccfbf142848616fbffae9f6baf72ab019101 / James Daugherty 
<[email protected]>
Code Review Feedback
  ControllerTagLibTypeCheckingExtension.groovy — 6 feedback items addressed:
  1. @since 8.0 — fixed from 7.0 to match the actual 8.0.0-SNAPSHOT project 
version
  2. Outer scope guards — added setup { newScope() } / finish { scopeExit() } 
for consistency with CriteriaTypeCheckingExtension and other extensions
  3. Explicit methodNotFound types — ClassNode receiver, String name, 
ArgumentListExpression argList, ClassNode[] argTypes, MethodCall call
  4. Typed isThisReceiver parameter — Expression expr
  5. Explicit return null at end of run()
  6. Javadoc updates — documents both the tag-as-property limitation (def t = 
link compiles but throws MissingPropertyException at runtime) and the inner 
class naming
  behavior

  CompileStaticControllerIntegrationSpec.groovy — renamed from 
CompileStaticControllerSpec (both filename and class name) to eliminate the FQN 
collision with the unit test.

  ControllerTagLibTypeCheckingExtensionSpec.groovy (new) — 3 negative tests 
verifying that the extension does not suppress errors for declared types: wrong 
method on a
  service field, type mismatch, and wrong method on a declared local variable.

Report URL: https://github.com/apache/grails-core/actions/runs/26838822187

With regards,
GitHub Actions via GitBox

Reply via email to