jamesfredley commented on code in PR #15557:
URL: https://github.com/apache/grails-core/pull/15557#discussion_r3343847991
##########
grails-test-examples/hibernate5/grails-hibernate/grails-app/init/functional/tests/BootStrap.groovy:
##########
@@ -26,7 +26,8 @@ class BootStrap {
HibernateDatastore hibernateDatastore
def init = {
- assert
hibernateDatastore.connectionSources.defaultConnectionSource.settings.hibernate.getConfigClass()
== CustomHibernateMappingContextConfiguration
+ // TODO: Re-enable when hibernate.configClass setting works with
Groovy 5 configuration binding
Review Comment:
Pushed as commit 013becf53e. One refinement from review: the committed
`ConfigurationBuilder` change handles a config value that is **already a
`Class`** (an `application.groovy` Class literal such as
`hibernate.naming_strategy = SomeClass`) as well as a class-name String - it
reads the raw value, returns it directly when it is already a `Class`, and
otherwise resolves a `CharSequence` via `ClassUtils.forName(name,
contextClassLoader)`. Reading the value raw also sidesteps Spring 7's
`MapToMapConverter` deep conversion. Since `ConfigurationBuilder` is shared by
every datastore, this avoids regressing existing Class-literal settings.
Covered by three specs in `HibernateConnectionSourceSettingsSpec` (FQCN String,
no-converter `StandardEnvironment`, and Class literal). Aligns with GORM's
canonical approach (grails-testing-support `5539ec0`).
##########
grails-core/src/main/groovy/grails/dev/commands/template/TemplateRendererImpl.groovy:
##########
@@ -55,7 +55,7 @@ class TemplateRendererImpl implements TemplateRenderer {
@Override
@CompileDynamic
void render(Map<String, Object> namedArguments) {
- if (namedArguments?.template && namedArguments?.destination) {
+ if (namedArguments?.template != null && namedArguments?.destination !=
null) {
Review Comment:
Committed in 3fbfc1aa4e (Restore Groovy truth for the template argument in
TemplateRendererImpl).
##########
grails-shell-cli/src/main/groovy/org/grails/cli/profile/commands/templates/TemplateRendererImpl.groovy:
##########
@@ -74,7 +74,7 @@ class TemplateRendererImpl implements TemplateRenderer,
ProfileRepositoryAware {
@Override
@CompileDynamic
void render(Map<String, Object> namedArguments) {
- if (namedArguments?.template && namedArguments?.destination) {
+ if (namedArguments?.template != null && namedArguments?.destination !=
null) {
Review Comment:
Committed in 3fbfc1aa4e (Restore Groovy truth for the template argument in
TemplateRendererImpl).
##########
grails-rest-transforms/src/main/groovy/grails/rest/RestfulController.groovy:
##########
@@ -66,8 +66,7 @@ class RestfulController<T> {
* @return A list of resources
*/
def index(Integer max) {
- if (max < 0) { max = null }
- params.max = Math.min(max ?: 10, 100)
+ params.max = Math.min(params.int('max', 10), 100)
Review Comment:
Committed in 369d674597 (Revert manual controller-action parameter
workarounds).
##########
grails-test-examples/cache/grails-app/controllers/com/demo/DemoController.groovy:
##########
@@ -69,47 +69,47 @@ class DemoController {
render "Value From Service Is
\"${basicCachingService.resetData()}\""
}
- def cachePut(String key, String value) {
- def result = basicCachingService.getData(key, value)
+ def cachePut() {
Review Comment:
Committed in 369d674597 (Revert manual controller-action parameter
workarounds).
##########
grails-test-examples/cache/grails-app/controllers/com/demo/AdvancedCachingController.groovy:
##########
@@ -33,9 +33,9 @@ class AdvancedCachingController {
// ========== null value endpoints ==========
- def dataOrNull(String input) {
+ def dataOrNull() {
Review Comment:
Committed in 369d674597 (Revert manual controller-action parameter
workarounds).
##########
grails-test-examples/mongodb/database-per-tenant/grails-app/controllers/examples/mongo/tenant/BookController.groovy:
##########
@@ -35,8 +35,8 @@ class BookController {
*/
def bindParams = ['title']
- def index(Integer max) {
- params.max = Math.min(max ?: 10, 100)
+ def index() {
Review Comment:
Committed in 369d674597 (Revert manual controller-action parameter
workarounds).
##########
grails-test-examples/mongodb/base/grails-app/controllers/functional/tests/BookController.groovy:
##########
@@ -37,8 +37,8 @@ class BookController {
*/
def bindParams = ['title']
- def index(Integer max) {
- params.max = Math.min(max ?: 10, 100)
+ def index() {
Review Comment:
Committed in 369d674597 (Revert manual controller-action parameter
workarounds).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
