codeconsole opened a new issue, #15712:
URL: https://github.com/apache/grails-core/issues/15712
### Expected Behavior
Two near-identical full-stack-trace knobs that can double-log. You now have:
- grails.exceptionresolver.logFullStackTrace →
logFullStackTraceIfEnabled() emits to STACK_LOG before filtering (resolver,
line 280).
- grails.exceptionresolver.logFullStackTraceOnFilter →
DefaultStackTraceFilterer.filter() emits to the same STACK_LOG with the same
FULL_STACK_TRACE_MESSAGE
(filterer, line 131).
If a user sets logFullStackTrace: true and leaves logFullStackTraceOnFilter
at its true default, the unfiltered trace is logged to StackTrace twice. The
names are nearly indistinguishable and the behaviors overlap. I'd reconcile to
one concept: make the resolver-level logFullStackTrace the single switch, and
have logFullStackTraceOnFilter either delegate to it or be documented as
deprecated/legacy. At minimum, guard against both firing. This is the thing
most likely to bite a user (and confuse a reviewer on the PR).
@jdaugherty you wanted to keep this in 7.x, can we clean this up in 8.x?
### Actual Behaviour
_No response_
### Steps To Reproduce
_No response_
### Environment Information
_No response_
### Example Application
_No response_
### Version
7.x
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
