jamesfredley commented on PR #15692: URL: https://github.com/apache/grails-core/pull/15692#issuecomment-4616209844
Updated this PR to avoid changing any behavior. The previous revision switched the call to `instance.delete(flush: true)`. While that fixed the misleading `failOnError` argument, it also **changed runtime behavior** by forcing an immediate flush on every delete - which is more than this cleanup should do. The latest commit instead changes the call to a plain `instance.delete()`: - The original `delete(failOnError: true)` was effectively a non-flushing `delete()`, since GORM's `delete(Map)` only honors the `flush` key and silently ignores `failOnError`. - Plain `delete()` keeps that exact behavior - **no flush change, no functional change**. - It simply removes the `failOnError` parameter, which created a false impression of doing something when it did nothing. In short: this is now a pure no-op cleanup that drops a dead parameter, not a behavior change. The interaction test was updated to assert `delete()` is called with no arguments and the ignored `failOnError` argument is never passed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
