The GitHub Actions job "CI - Groovy Joint Validation Build" on 
grails-core.git/feat/sitemesh3-default-layout has failed.
Run started by GitHub user codeconsole (triggered by codeconsole).

Head commit for run:
8a1fbcbcd1e643c302d3f6c465fc69c9c6ab1d25 / Scott Murphy Heiberg 
<[email protected]>
Don't apply a SiteMesh 3 layout to template/partial renders

A controller's "render template: 'x'" renders the GSP directly with
renderView=false and must not be decorated with a layout. Under the
filterless SiteMesh 3 integration the template view was still wrapped by
GrailsSiteMeshView and Sitemesh3LayoutFinder picked the default layout,
so partials came back wrapped in the application layout (e.g. the main
layout's title instead of the partial's own). SiteMesh 2 suppressed this
via GrailsLayoutSelector keyed on the renderView flag.

Sitemesh3LayoutFinder.selectDecoratorPaths now returns no decorator when
the current render has renderView=false and no explicit layout was
requested. An explicit "render template: ..., layout: 'x'" still sets the
LAYOUT_ATTRIBUTE and is honoured, and normal view renders (renderView=true)
are unaffected, so decorated pages still decorate.

Verified under SITEMESH3_TESTING_ENABLED=true: LayoutWithTemplateSpec
passes; BookFunctionalSpec (meta-layout pages), ControllerIncludesSpec
(incl. include-from-template), ConfigTestControllerSpec and
scaffolding-fields RelationshipsFunctionalSpec remain green.

Report URL: https://github.com/apache/grails-core/actions/runs/27075661961

With regards,
GitHub Actions via GitBox

Reply via email to