jamesfredley commented on PR #15713: URL: https://github.com/apache/grails-core/pull/15713#issuecomment-4674291612
I re-checked the current PR head (`bb94c8c27d`) against the earlier SM2 parity list. A few items look addressed now, but these still look partial or unresolved: | Item | Status | Notes | | --- | --- | --- | | `g:applyLayout` attribute parity | Partial | `RenderSitemeshTagLib.groovy:78` now handles body, `name`, and `params` (`:112`, `:122`), but still does not support the SM2 attribute surface: `template`, `url`, `action`, `controller`, `model`, `contentType`, `encoding`, or `parse`. | | Default layout config + implicit `application` fallback | Unresolved | SM3 still reads only `grails.sitemesh.default.layout` (`Sitemesh3GrailsPlugin.groovy:83`) and passes `null` when unset (`:102`). It does not consult `grails.views.layout.default`, and does not match SM2's implicit `application` fallback behavior (`GroovyPageLayoutFinder.groovy:180`). | | `grails.views.layout.enable.nongsp` | Unresolved | SM2 wires this through `LayoutGrailsPlugin.groovy:38` and `GroovyPageLayoutFinder.groovy:87`. I do not see an SM3 equivalent in `Sitemesh3LayoutFinder.java`, which still only resolves via the GSP locator. | | `<title>` stripping robustness | Unresolved | `Sitemesh3CapturedPage.java:232` still searches for `"<title"` without checking the tag boundary, so cases like `<titlebar>` / `<title-x>` can still be misidentified before the real `</title>` is found. | | Upstream auto-config suppression guard | Partial | There is improved view-resolver auto-config (`Sitemesh3AutoConfiguration.java:38`), but the plugin still relies on a disabled bean named `sitemesh` with `NoopSitemeshFilter` (`Sitemesh3GrailsPlugin.groovy:112`, `:125`). I do not see a guard test proving the upstream filter auto-config stays suppressed. | | Test examples default path | Partial | Most examples now default to SM3 via `SITEMESH2_TESTING_ENABLED`, but the Hibernate 7 examples still use the old/inverted `SITEMESH3_TESTING_ENABLED` toggle and therefore default to SM2 when unset, e.g. `grails-test-examples/hibernate7/grails-hibernate/build.gradle:41`. | | SM2-only examples without SM3 coverage | Partial | `database-cleanup`, `scaffolding-fields`, and `test-phases` were fixed, but `scaffolding` and `jetty` remain hardcoded to `grails-layout` only (`scaffolding/build.gradle:49`, `jetty/build.gradle:41`). `gsp-layout` can probably remain the intentional SM2 anchor. | | CI coverage for SM2 lane | Unresolved | I do not see `SITEMESH2_TESTING_ENABLED` or `SITEMESH3_TESTING_ENABLED` in `.github/workflows`. The default SM3 path is exercised, but there is no explicit SM2 compatibility lane. | | `grails-gsp-spring-boot` publication | Unresolved | The project is included in `settings.gradle:175` and depends on `grails-sitemesh3` (`grails-gsp/spring-boot/build.gradle:37`), but it is still absent from the published projects list in `gradle/publish-root-config.gradle` while `grails-sitemesh3` is listed at `:76`. | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
