jamesfredley commented on PR #15698: URL: https://github.com/apache/grails-core/pull/15698#issuecomment-4674690137
Updated the PR with three follow-up commits after the latest review: - `e9afa4d11b` - Configures `bootRun` in the Grails Gradle plugin to provide the default `cli.pid.file` at `build/run-app.pid`, while preserving the explicit CLI-supplied PID path from `run-app`. Added TestKit coverage for both paths. - `ff748be2f7` - Simplifies the `stop-app` command docs to focus on user-facing behavior instead of PID/JMX/Actuator internals. - `d9a96cf89a` - Keeps legacy `--host` and `--port` declared but fails fast before any run-app state, stop marker, PID lookup, or process termination is touched. Verification run locally: - `./gradlew :grails-gradle-plugins:test --tests org.grails.gradle.plugin.core.GrailsGradlePluginToolchainSpec` - `./gradlew :grails-shell-cli:test --tests org.grails.cli.gradle.RunningApplicationProcessSpec` - `./gradlew :grails-profiles-base:compileProfile` - Manual Groovy driver stopped a real `sleep` process via `RunningApplicationProcess.stop()` and treated a malformed PID file as `NOT_RUNNING`. I also updated the PR description to match the current design and replied to the review threads about docs and the interactive `run-app`/`stop-app` failure. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
