codeconsole commented on code in PR #15720:
URL: https://github.com/apache/grails-core/pull/15720#discussion_r3399300843
##########
grails-core/src/main/groovy/grails/compiler/GrailsCompileStatic.groovy:
##########
@@ -33,5 +33,6 @@ import groovy.transform.CompileStatic
'org.grails.compiler.WhereQueryTypeCheckingExtension',
'org.grails.compiler.DynamicFinderTypeCheckingExtension',
'org.grails.compiler.DomainMappingTypeCheckingExtension',
+ 'org.grails.compiler.CriteriaTypeCheckingExtension',
Review Comment:
Added in b10f36fae9. The TCK now executes criteria queries that were
compiled with `@GrailsCompileStatic`, covering both dispatch paths the
extension produces: statically-resolved `Criteria` API calls and the dynamic
fallback (`projections`, `min`/`countDistinct`/`property`, `maxResults`, and
the chained `count { }` terminal, which is not declared on
`BuildableCriteria`). Verified green against the in-memory, Hibernate 5,
Hibernate 7, and MongoDB implementations locally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
