The GitHub Actions job "CI" on grails-core.git/fix/stop-app-cli has failed.
Run started by GitHub user jamesfredley (triggered by jamesfredley).

Head commit for run:
9a132a87fa94647e9f66a901209443a42e9c0bab / James Fredley 
<[email protected]>
Simplify run-app/stop-app PID file handoff per review

Address review feedback on the PID-file based stop-app:

- Scope the PID system property as grails.cli.pid.file and set it
  directly on the bootRun task; GrailsApp reads the scoped name.
- Configure the bootRun PID file via pluginManager.withPlugin and a
  CommandLineArgumentProvider (RunAppPidFileProvider) so the path is
  resolved lazily at execution time and stays configuration-cache safe,
  replacing the afterEvaluate plus configuration-time resolution.
- Hard-code the PID file at build/run-app.pid; remove the run-app and
  stop-app command/system/config overrides so producer and consumer
  always agree on one location.
- Drop the internal grails.cli.pid.file entry and Command Line group
  from the Spring configuration metadata and the doc ordering; it is
  internal CLI wiring, not user configuration.
- Keep and document the run-app.stopping marker: stop-app signals only
  the forked application JVM, so bootRun exits non-zero and a foreground
  run-app needs the marker to tell a deliberate stop from a startup
  failure.

Assisted-by: claude-code:claude-4.8-opus

Report URL: https://github.com/apache/grails-core/actions/runs/27654465501

With regards,
GitHub Actions via GitBox

Reply via email to